ryze/ff2mpv-rust
1
0
Fork 0
Code Issues Pull requests Releases 8 Activity

Spawn player with CREATE_BREAKAWAY_FROM_JOB on Windows #6

Merged
ryze312 merged 1 commit from windows_launch_bug into main 2023-10-21 20:39:13 +02:00
Conversation 0 Commits 1 Files changed 1 +19 -6
1 changed files with 19 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit b0595f172d - Show all commits

25
src/command.rs
View file

@ -70,12 +70,25 @@ impl Command {
} }
fn launch_mpv(command: String, args: Vec<String>, url: &str) -> Result<(), io::Error> { fn launch_mpv(command: String, args: Vec<String>, url: &str) -> Result<(), io::Error> {
process::Command::new(command) let mut command = process::Command::new(command);
.stdout(process::Stdio::null())
.stderr(process::Stdio::null()) command.stdout(process::Stdio::null());
.args(args) command.stderr(process::Stdio::null());
.arg(url) command.args(args);
.spawn()?; command.arg(url);
// NOTE: On Windows, browser spawns process into a Job object.
// NOTE: We need to detach player from the job, so it won't get killed after we're done,
// NOTE: See https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_messaging#closing_the_native_app
#[cfg(target_family = "windows")]
{
use std::os::windows::process::CommandExt;
const CREATE_BREAKAWAY_FROM_JOB: u32 = 0x01000000;
command.creation_flags(CREATE_BREAKAWAY_FROM_JOB);
}
command.spawn()?;
Ok(()) Ok(())
} }