ryze/ff2mpv-rust
1
0
Fork 0
Code Issues Pull requests Releases 8 Activity

Spawn player with CREATE_BREAKAWAY_FROM_JOB on Windows #6

Merged
ryze312 merged 1 commit from windows_launch_bug into main 2023-10-21 20:39:13 +02:00
Conversation 0 Commits 1 Files changed 1 +19 -6
ryze312 commented 2023-10-21 20:36:07 +02:00 (Migrated from github.com)
Copy link

We need to spawn player with CREATE_BREAKAWAY_FROM_JOB creation flag, so it doesn't get killed after ff2mpv-rust gets closed.

See this section of MDN article on Native messaging for more info.

Fixes #5

We need to spawn player with `CREATE_BREAKAWAY_FROM_JOB` creation flag, so it doesn't get killed after ff2mpv-rust gets closed. See [this section](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_messaging#closing_the_native_app) of MDN article on Native messaging for more info. Fixes #5
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ryze/ff2mpv-rust#6
No description provided.
Delete branch "windows_launch_bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?