Respect options passed by ff2mpv extension #12

Merged

eNV25 merged 2 commits from pr/use-args into main

2024-02-16 09:33:12 +01:00

eNV25 commented

2024-02-15 15:24:58 +01:00

(Migrated from github.com)

The upstream ff2mpv extension started passing options. Respect
those by passing them after our config.player_args.

The upstream ff2mpv extension started passing `options`. Respect those by passing them after our `config.player_args`.

ryze312 commented

2024-02-16 09:15:08 +01:00

(Migrated from github.com)

Thanks for the PR!
This somehow slipped under my radar, when I was looking at the Python script recently. Let's include the profile options.

Thanks for the PR! This somehow slipped under my radar, when I was looking at the Python script recently. Let's include the profile options.

ryze312 (Migrated from github.com) requested changes 2024-02-16 09:31:48 +01:00

src/command.rs

ryze312 (Migrated from github.com) commented

2024-02-16 09:30:50 +01:00

Let's keep the order of imports as is, i.e:

std
External crates
Local crates

use std::env;
use std::io;
use std::process;
use serde_json::{self, json};

Let's keep the order of imports as is, i.e: 1. `std` 2. External crates 3. Local crates ```suggestion use std::env; use std::io; use std::process; use serde_json::{self, json}; ```

No reviewers

ryze312

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ryze/ff2mpv-rust#12

No description provided.