ryze/ff2mpv-rust
1
0
Fork 0
Code Issues Pull requests Releases 8 Activity

Respect options passed by ff2mpv extension #12

Merged
eNV25 merged 2 commits from pr/use-args into main 2024-02-16 09:33:12 +01:00
Conversation 1 Commits 2 Files changed 2 +1 -1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit d5a572d8d3 - Show all commits

2
src/command.rs
View file

@ -1,7 +1,7 @@
ryze312 commented 2024-02-16 09:30:50 +01:00 (Migrated from github.com)
Review
Copy link

Let's keep the order of imports as is, i.e:

  1. std
  2. External crates
  3. Local crates
use std::env;
use std::io;
use std::process;
use serde_json::{self, json};
Let's keep the order of imports as is, i.e: 1. `std` 2. External crates 3. Local crates ```suggestion use std::env; use std::io; use std::process; use serde_json::{self, json}; ```
ryze312 commented 2024-02-16 09:30:50 +01:00 (Migrated from github.com)
Review
Copy link

Let's keep the order of imports as is, i.e:

  1. std
  2. External crates
  3. Local crates
use std::env;
use std::io;
use std::process;
use serde_json::{self, json};
Let's keep the order of imports as is, i.e: 1. `std` 2. External crates 3. Local crates ```suggestion use std::env; use std::io; use std::process; use serde_json::{self, json}; ```
use serde_json::{self, json};
ryze312 commented 2024-02-16 09:30:50 +01:00 (Migrated from github.com)
Review
Copy link

Let's keep the order of imports as is, i.e:

  1. std
  2. External crates
  3. Local crates
use std::env;
use std::io;
use std::process;
use serde_json::{self, json};
Let's keep the order of imports as is, i.e: 1. `std` 2. External crates 3. Local crates ```suggestion use std::env; use std::io; use std::process; use serde_json::{self, json}; ```
use std::env; use std::env;
use std::io; use std::io;
use std::process; use std::process;
use serde_json::{self, json};
ryze312 commented 2024-02-16 09:30:50 +01:00 (Migrated from github.com)
Review
Copy link

Let's keep the order of imports as is, i.e:

  1. std
  2. External crates
  3. Local crates
use std::env;
use std::io;
use std::process;
use serde_json::{self, json};
Let's keep the order of imports as is, i.e: 1. `std` 2. External crates 3. Local crates ```suggestion use std::env; use std::io; use std::process; use serde_json::{self, json}; ```
use crate::browser; use crate::browser;
use crate::config::Config; use crate::config::Config;

ryze312 commented 2024-02-16 09:30:50 +01:00 (Migrated from github.com)
Review
Copy link

Let's keep the order of imports as is, i.e:

  1. std
  2. External crates
  3. Local crates
use std::env;
use std::io;
use std::process;
use serde_json::{self, json};
Let's keep the order of imports as is, i.e: 1. `std` 2. External crates 3. Local crates ```suggestion use std::env; use std::io; use std::process; use serde_json::{self, json}; ```
ryze312 commented 2024-02-16 09:30:50 +01:00 (Migrated from github.com)
Review
Copy link

Let's keep the order of imports as is, i.e:

  1. std
  2. External crates
  3. Local crates
use std::env;
use std::io;
use std::process;
use serde_json::{self, json};
Let's keep the order of imports as is, i.e: 1. `std` 2. External crates 3. Local crates ```suggestion use std::env; use std::io; use std::process; use serde_json::{self, json}; ```