Use `--` to separate args and URLs #10

New issue

Closed

opened 2024-02-08 18:34:41 +01:00 by minijackson · 1 comment

minijackson commented

2024-02-08 18:34:41 +01:00

(Migrated from github.com)

Hello and thanks for this tool!

I've noticed that the original ff2mpv code was using -- to separate args and urls, like this:

mpv --args -- $url

Which I think is good from a security perspective. Would you be open to adding it?

I've also seen that it always adds --no-terminal to the options (see https://github.com/woodruffw/ff2mpv/issues/1)

Hello and thanks for this tool! I've noticed that the [original `ff2mpv` code](https://github.com/woodruffw/ff2mpv/blob/master/ff2mpv) was using `--` to separate args and urls, like this: ```bash mpv --args -- $url ``` Which I think is good from a security perspective. Would you be open to adding it? I've also seen that it always adds `--no-terminal` to the options (see https://github.com/woodruffw/ff2mpv/issues/1)

ryze312 commented

2024-02-14 07:15:17 +01:00

(Migrated from github.com)

Hey thanks for the suggestion! This is certainly a good idea, will implement shortly.

❤️ 1