ryze/ff2mpv-rust
1
0
Fork 0
Code Issues Pull requests Releases 8 Activity

Use -- to separate args and URL

Browse source 
Fixes #10
This commit is contained in:
Ryze 2024-02-14 10:52:24 +03:00
parent 44cf917ecf
commit 550bd3a818
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/command.rs
View file

@ -65,7 +65,7 @@ impl Command {
let ff2mpv_message = browser::get_mpv_message()?; let ff2mpv_message = browser::get_mpv_message()?;
Command::launch_mpv(config.player_command, config.player_args, &ff2mpv_message.url)?; Command::launch_mpv(config.player_command, config.player_args, &ff2mpv_message.url)?;
browser::send_reply()?; browser::send_reply()?;
Ok(()) Ok(())
} }
@ -75,12 +75,13 @@ impl Command {
command.stdout(process::Stdio::null()); command.stdout(process::Stdio::null());
command.stderr(process::Stdio::null()); command.stderr(process::Stdio::null());
command.args(args); command.args(args);
command.arg("--");
command.arg(url); command.arg(url);
// NOTE: On Windows, browser spawns process into a Job object. // NOTE: On Windows, browser spawns process into a Job object.
// NOTE: We need to detach player from the job, so it won't get killed after we're done, // NOTE: We need to detach player from the job, so it won't get killed after we're done,
// NOTE: See https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_messaging#closing_the_native_app // NOTE: See https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_messaging#closing_the_native_app
#[cfg(target_family = "windows")] #[cfg(target_family = "windows")]
{ {
use std::os::windows::process::CommandExt; use std::os::windows::process::CommandExt;
const CREATE_BREAKAWAY_FROM_JOB: u32 = 0x01000000; const CREATE_BREAKAWAY_FROM_JOB: u32 = 0x01000000;