Cina Saffary
d647227bbc
Refactor subprocess execution to use @actions/exec
...
Instead of using a mix of `child_process.exec`, `child_process.execSync` and a promisified version of `child_process.exec`, we now (mostly) just use `@actions/exec`. That runs `child_process.spawn` under the hood and handles a lot of character escaping for us. We can also now pass Buffers directly into the subprocess as stdin instead of relying on shell piping.
This ends up fixing a few problems we had where secrets and env var values containing shell metacharacters were being misinterpreted.
Unfortunately, `@actions/exec` doesn't support running with a shell. That means we still have to roll our own wrapper around `child_process.exec` to avoid a breaking change to `preCommands` and `postCommands`, since users might be expecting these to run within a shell.
Also worth noting that we're no longer hiding stdout and stderr from the secret uploading step. We were previously doing this out of an abundance of caution, but it made debugging issues very difficult if secret upload failed for some reason. I feel ok doing this since we're no longer echoing & piping the secret values, wrangler doesn't ever output secret values, and as a last line of defense GitHub masks any secret values that accidentally get logged.
2023-10-18 16:42:34 -05:00
Somhairle MacLeòid
533097350a
Merge pull request #196 from cloudflare/penalosa-patch-1
2023-10-12 00:55:30 +01:00
Cina Saffary
bc7253f187
Merge pull request #195 from cloudflare/changeset-release/main
...
Version Packages
2023-10-11 11:33:03 -05:00
github-actions[bot]
b2e459a047
Version Packages
2023-10-11 16:31:53 +00:00
Cina Saffary
96c3774b77
Merge pull request #197 from cloudflare/cina/add-missing-licenses-to-test-packages
...
Add missing licenses to dummy test packages
2023-10-11 11:31:22 -05:00
Cina Saffary
b00f94ea6f
Merge pull request #183 from cloudflare/dependabot/npm_and_yarn/postcss-8.4.31
...
Bump postcss from 8.4.27 to 8.4.31
2023-10-11 11:08:41 -05:00
dependabot[bot]
c649733249
Bump postcss from 8.4.27 to 8.4.31
...
Bumps [postcss](https://github.com/postcss/postcss ) from 8.4.27 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases )
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md )
- [Commits](https://github.com/postcss/postcss/compare/8.4.27...8.4.31 )
---
updated-dependencies:
- dependency-name: postcss
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-10-11 16:04:26 +00:00
Cina Saffary
d43f9c81c7
Set dummy test packages as private
2023-10-11 10:59:27 -05:00
Cina Saffary
219a0887d7
Add missing licenses to dummy test packages
...
This is mostly to prevent yarn from throwing a warning during our test runs
2023-10-11 10:56:07 -05:00
Somhairle MacLeòid
25b114f472
Update pullrequests.yml
2023-10-11 15:24:12 +01:00
Cina Saffary
f40a9f5f82
Merge pull request #193 from cloudflare/cina/fix-packagemanager-default
...
Don't set `packageManager` default via action.yml
2023-10-11 03:54:35 -05:00
Cina Saffary
bd06b290b1
Fix code formatting errors
2023-10-10 18:00:40 -05:00
Cina Saffary
a4509d507c
Don't set packageManager default via action.yml
...
We need to distinguish between when the value is and isn't set in order to perform inference based on lockfile and only fallback to the default of npm if inference fails.
2023-10-10 18:00:32 -05:00
Cina Saffary
0e6f0d3080
Merge pull request #192 from cloudflare/changeset-release/main
...
Version Packages
2023-10-10 15:23:32 -05:00
github-actions[bot]
326ba30882
Version Packages
2023-10-10 20:20:04 +00:00
Cina Saffary
032a7248fa
Merge pull request #188 from simpleauthority/feat/add-bun-support
...
Add bun support
2023-10-10 15:19:09 -05:00
Jacob Andersen
080373bdb6
Add bun as a package manager option in action.yml
2023-10-10 13:17:05 -07:00
Cina Saffary
231d787db1
Update test/bun/package.json
2023-10-10 15:05:59 -05:00
Jacob Andersen
d9a0a00f8b
Add changeset
2023-10-10 12:41:00 -07:00
Jacob Andersen
779191a652
add bun support
2023-10-10 12:36:03 -07:00
Cina Saffary
556068fb59
Merge pull request #191 from cloudflare/changeset-release/main
...
Version Packages
2023-10-10 09:25:51 -05:00
github-actions[bot]
caa59485d0
Version Packages
2023-10-10 14:16:00 +00:00
Cina Saffary
c2494c1ca6
Merge pull request #190 from cloudflare/cina/180-fix-undefined-package-manager
...
Use npm as fallback if no `packageManager` specified
2023-10-10 09:14:13 -05:00
Cina Saffary
528687aaf4
Refactor to use npm as a fallback if no packageManager specified...
...
and no lockfile is present. Fixes #180
2023-10-09 17:20:09 -05:00
lrapoport-cf
bd50d10af9
Merge pull request #185 from cloudflare/lrapoport/fix-issue-workflow
...
Fix issue workflow
2023-10-05 15:34:02 -04:00
lrapoport-cf
2513ffc6cc
Fix workflow syntax for multiple conditions
2023-10-05 15:29:35 -04:00
lrapoport-cf
9df50d42e4
Merge pull request #182 from cloudflare/lrapoport/update-issues-workflow
...
Update issues workflow
2023-10-05 15:06:06 -04:00
lrapoport-cf
4611c14c05
Fix format
2023-10-05 15:01:41 -04:00
lrapoport-cf
ac3f259fcf
Add PR workflow
2023-10-02 11:29:17 -04:00
lrapoport-cf
b2645622e9
Rename issue workflow and job
2023-10-02 11:29:03 -04:00
lrapoport-cf
f4e6269765
Add transferred issues to workers-sdk GH project
2023-10-02 11:26:14 -04:00
Cina Saffary
72931e59b2
Merge pull request #174 from cloudflare/changeset-release/main
...
Version Packages
2023-10-02 10:23:58 -05:00
github-actions[bot]
e0254d06bc
Version Packages
2023-09-18 19:12:19 +00:00
Jacob M-G Evans
13d70757d2
Merge pull request #166 from nix6839/many-package-manager
...
Support many package managers
2023-09-18 14:11:51 -05:00
Han Yeong-woo
aec73ae744
Add wangler files in fixtures
2023-09-19 03:52:00 +09:00
Han Yeong-woo
f0cc3efccf
Install yarn and pnpm on test
2023-09-19 03:51:27 +09:00
Han Yeong-woo
50b529e7b8
Fix pass arg issue
2023-09-19 03:50:54 +09:00
Han Yeong-woo
6771675815
Run format
2023-09-19 01:37:01 +09:00
Jacob M-G Evans
4ae0557f8d
Update two-rocks-hope.md
2023-09-18 11:33:50 -05:00
Han Yeong-woo
7d7b98826e
Add changeset
2023-09-19 01:30:36 +09:00
Han Yeong-woo
d1073d57ba
Run format
2023-09-19 01:30:35 +09:00
Han Yeong-woo
c3b99e2c18
Ignore to pnpm-lock.yaml in formatting
2023-09-19 01:30:35 +09:00
Han Yeong-woo
2375787b23
Move test fixtures to parent directory
2023-09-19 01:30:35 +09:00
Han Yeong-woo
11f981cea4
Add tests for package managers support
2023-09-19 01:30:34 +09:00
Han Yeong-woo
868dbd9a40
Remove unused function
2023-09-19 01:30:34 +09:00
Han Yeong-woo
a009342d77
Add packageManager setting
2023-09-19 01:30:34 +09:00
Han Yeong-woo
f2e4cda4dd
Detect package manager and uses its commands
...
Fix #156
2023-09-19 01:30:33 +09:00
Han Yeong-woo
f4f2e854d7
Add isValidPackcageManager() util
2023-09-19 01:30:33 +09:00
Han Yeong-woo
cbe5f5b523
Add detect package manager util function
2023-09-19 01:30:33 +09:00
Jacob M-G Evans
fcf2d83f3d
Merge pull request #172 from cloudflare/demosjarco/main
...
Node 20 update
2023-09-18 11:29:49 -05:00
