Commit graph

295 commits

Author SHA1 Message Date
David Wheatley
ba0f485178
docs: update link to api token generation instructions 2023-12-20 02:07:57 +00:00
Cina Saffary
2de0b3dfd8
Merge pull request #218 from cloudflare/changeset-release/main
Version Packages
2023-12-19 11:52:32 -06:00
github-actions[bot]
f2d9b652c4 Version Packages 2023-12-13 17:17:49 +00:00
Cina Saffary
0e62acaf21
Merge pull request #213 from GrantBirki/write-results-to-a-file
Save Wrangler Command Output to a Variable
2023-12-13 11:17:24 -06:00
Cina Saffary
bd3857047e
Apply suggestions from code review 2023-12-13 11:15:50 -06:00
GrantBirki
d13856dfc9
add changeset 2023-12-13 10:10:20 -07:00
Grant Birkinbine
f88aee4953
Merge branch 'main' into write-results-to-a-file 2023-12-13 10:04:14 -07:00
Grant Birkinbine
a5f361f3f0
Update src/index.ts
Co-authored-by: Cina Saffary <itscina@gmail.com>
2023-12-13 10:02:54 -07:00
James Ross
9aba9c34da
fix: semver comparison (#216)
* fix: semver comparison

chore: bump dependencies

* chore: add changeset

* fix: update snapshot for error test
2023-12-13 09:53:47 +00:00
Grant Birkinbine
9dd38ad790
Update package.json 2023-12-12 22:34:31 -07:00
Grant Birkinbine
1599928d8e
Update src/index.ts 2023-12-12 22:24:09 -07:00
Grant Birkinbine
0fff39f4b7
Update action.yml
Co-authored-by: Cina Saffary <itscina@gmail.com>
2023-12-12 22:19:53 -07:00
GrantBirki
ca0bf5eeba
properly check for pages deployments 2023-12-07 23:17:03 -07:00
GrantBirki
97c920b38e
parse and set the deployment-url 2023-12-07 22:48:10 -07:00
GrantBirki
11fa60953d
set another output for stderr as it will almost always contain 'some' data 2023-12-07 22:30:51 -07:00
GrantBirki
5ee7b681bc
update readme 2023-12-07 22:27:25 -07:00
GrantBirki
74a612d924
swap from file to output variable 2023-12-07 22:26:06 -07:00
GrantBirki
0558fc8c04
swap to commandOutput 2023-12-07 22:13:33 -07:00
GrantBirki
976ec4d78c
bump minor version 2023-12-01 11:12:34 -07:00
GrantBirki
a8845f6d95
update docs 2023-12-01 11:10:27 -07:00
GrantBirki
8d6fade5ad
save primary wrangler command output to a file (optionally) 2023-12-01 11:04:51 -07:00
Cina Saffary
65996a5230
Merge pull request #205 from cloudflare/cina/184-skip-release-if-tags-exist
Don't attempt to publish when there's no pending release
2023-10-31 10:54:14 -05:00
Cina Saffary
2b7ed1316d Don't trigger release process when there's no release
Currently our release process is kicked off whenever a PR is merged and there are no changesets within the `.changeset` directory. Typically this happens when we intend to publish a release, just after we merge a "Version Packages" PR which removes the changesets and adds the entries to our changelog.

However, this also means that merging any PR without user-facing changes during the period after we've made a release will trigger another release (which luckily fails because the created tag already exists on the remote. See #184).

This change avoids that scenario by fetching tags when checking out the repo. Now when `npx changeset tag` runs, it will see that the tag already exists and skip creating it (`🦋  Skipping tag (already exists):  v3.3.2`). The `git push --tags` step will no longer throw an error ("Everything up-to-date"). And lastly, the publish step won't get triggered because the output from `npx changeset tag` doesn't contain the string `"New tag:"`. The action should just finish successfully with nothing to left do.

Fixes #184
2023-10-31 10:21:29 -05:00
Cina Saffary
9554b3575b
Merge pull request #204 from jgentes/patch-1
Swap CF_API_TOKEN with CLOUDFLARE_API_TOKEN
2023-10-30 15:21:15 -05:00
James Gentes
57159ca2ed updated CF_ACCOUNT_ID 2023-10-30 13:17:34 -07:00
James Gentes
7dd5c3621b
Swap CF_API_TOKEN with CLOUDFLARE_API_TOKEN
If the token isn't specified, wrangler throws this error, indicating the CLOUDFLARE_API_TOKEN should be set, so it's worth being consistent so folks can copy/paste the examples and have it work out of the box:
```
In a non-interactive environment, it's necessary to set a CLOUDFLARE_API_TOKEN environment variable for wrangler to work.
```
2023-10-29 17:34:03 -07:00
Cina Saffary
581e17bc51
Merge pull request #201 from cloudflare/changeset-release/main
Version Packages
2023-10-24 13:45:26 -05:00
github-actions[bot]
21a8414ba3 Version Packages 2023-10-19 17:39:52 +00:00
Cina Saffary
819ea006e6
Merge pull request #171 from cloudflare/cina/refactor-subprocess-exec
Refactor subprocess execution to use `@actions/exec`
2023-10-19 12:39:18 -05:00
Cina Saffary
473d9cbd29 Bump DEFAULT_WRANGLER_VERSION to 3.13.2 2023-10-18 17:04:41 -05:00
Cina Saffary
76d614f400 Add changeset 2023-10-18 16:42:34 -05:00
Cina Saffary
d647227bbc Refactor subprocess execution to use @actions/exec
Instead of using a mix of `child_process.exec`, `child_process.execSync` and a promisified version of `child_process.exec`, we now (mostly) just use `@actions/exec`. That runs `child_process.spawn` under the hood and handles a lot of character escaping for us. We can also now pass Buffers directly into the subprocess as stdin instead of relying on shell piping.

This ends up fixing a few problems we had where secrets and env var values containing shell metacharacters were being misinterpreted.

Unfortunately, `@actions/exec` doesn't support running with a shell. That means we still have to roll our own wrapper around `child_process.exec` to avoid a breaking change to `preCommands` and `postCommands`, since users might be expecting these to run within a shell.

Also worth noting that we're no longer hiding stdout and stderr from the secret uploading step. We were previously doing this out of an abundance of caution, but it made debugging issues very difficult if secret upload failed for some reason. I feel ok doing this since we're no longer echoing & piping the secret values, wrangler doesn't ever output secret values, and as a last line of defense GitHub masks any secret values that accidentally get logged.
2023-10-18 16:42:34 -05:00
Somhairle MacLeòid
533097350a
Merge pull request #196 from cloudflare/penalosa-patch-1 2023-10-12 00:55:30 +01:00
Cina Saffary
bc7253f187
Merge pull request #195 from cloudflare/changeset-release/main
Version Packages
2023-10-11 11:33:03 -05:00
github-actions[bot]
b2e459a047 Version Packages 2023-10-11 16:31:53 +00:00
Cina Saffary
96c3774b77
Merge pull request #197 from cloudflare/cina/add-missing-licenses-to-test-packages
Add missing licenses to dummy test packages
2023-10-11 11:31:22 -05:00
Cina Saffary
b00f94ea6f
Merge pull request #183 from cloudflare/dependabot/npm_and_yarn/postcss-8.4.31
Bump postcss from 8.4.27 to 8.4.31
2023-10-11 11:08:41 -05:00
dependabot[bot]
c649733249
Bump postcss from 8.4.27 to 8.4.31
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.27 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/8.4.27...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-10-11 16:04:26 +00:00
Cina Saffary
d43f9c81c7 Set dummy test packages as private 2023-10-11 10:59:27 -05:00
Cina Saffary
219a0887d7 Add missing licenses to dummy test packages
This is mostly to prevent yarn from throwing a warning during our test runs
2023-10-11 10:56:07 -05:00
Somhairle MacLeòid
25b114f472
Update pullrequests.yml 2023-10-11 15:24:12 +01:00
Cina Saffary
f40a9f5f82
Merge pull request #193 from cloudflare/cina/fix-packagemanager-default
Don't set `packageManager` default via action.yml
2023-10-11 03:54:35 -05:00
Cina Saffary
bd06b290b1 Fix code formatting errors 2023-10-10 18:00:40 -05:00
Cina Saffary
a4509d507c Don't set packageManager default via action.yml
We need to distinguish between when the value is and isn't set in order to perform inference based on lockfile and only fallback to the default of npm if inference fails.
2023-10-10 18:00:32 -05:00
Cina Saffary
0e6f0d3080
Merge pull request #192 from cloudflare/changeset-release/main
Version Packages
2023-10-10 15:23:32 -05:00
github-actions[bot]
326ba30882 Version Packages 2023-10-10 20:20:04 +00:00
Cina Saffary
032a7248fa
Merge pull request #188 from simpleauthority/feat/add-bun-support
Add bun support
2023-10-10 15:19:09 -05:00
Jacob Andersen
080373bdb6
Add bun as a package manager option in action.yml 2023-10-10 13:17:05 -07:00
Cina Saffary
231d787db1
Update test/bun/package.json 2023-10-10 15:05:59 -05:00
Jacob Andersen
d9a0a00f8b
Add changeset 2023-10-10 12:41:00 -07:00