Merge pull request #345 from cloudflare/fix/pages-gh-deployment

fix: pages github deployment not triggering due to incorrect condition #2
This commit is contained in:
Maximo Guk 2025-01-17 09:47:27 -06:00 committed by GitHub
commit fc89533f1e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 6 additions and 26 deletions

View file

@ -0,0 +1,5 @@
---
"wrangler-action": patch
---
fix: Pages GitHub Deployment not triggering

View file

@ -92,8 +92,7 @@ export async function createGitHubDeploymentAndJobSummary(
config.GITHUB_TOKEN &&
pagesArtifactFields.production_branch &&
pagesArtifactFields.pages_project &&
pagesArtifactFields.deployment_trigger &&
pagesArtifactFields.stages
pagesArtifactFields.deployment_trigger
) {
const octokit = getOctokit(config.GITHUB_TOKEN);
await Promise.all([

View file

@ -17,30 +17,6 @@ const OutputEntryPagesDeployment = OutputEntryBase.merge(
// optional, added in wrangler@3.89.0
production_branch: z.string().optional(),
// optional, added in wrangler@3.89.0
stages: z
.array(
z.object({
name: z.enum([
"queued",
"initialize",
"clone_repo",
"build",
"deploy",
]),
status: z.enum([
"idle",
"active",
"canceled",
"success",
"failure",
"skipped",
]),
started_on: z.string().nullable(),
ended_on: z.string().nullable(),
}),
)
.optional(),
// optional, added in wrangler@3.89.0
deployment_trigger: z
.object({
metadata: z.object({