OwlBurst/Ponysearch
1
0
Fork 0
forked from Ponysearch/Ponysearch
Code Pull requests Activity

Merge pull request #749 from not-my-profile/fix-redundant-cookies

Browse source 
[fix] make BooleanChoices only set cookies that vary from the default
This commit is contained in:
Markus Heiser 2022-01-13 20:28:03 +01:00 committed by GitHub
commit 74847fe902
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
searx/preferences.py
View file

@ -205,6 +205,7 @@ class BooleanChoices:
self.name = name self.name = name
self.choices = choices self.choices = choices
self.locked = locked self.locked = locked
self.default_choices = dict(choices)
def transform_form_items(self, items): def transform_form_items(self, items):
# pylint: disable=no-self-use # pylint: disable=no-self-use
@ -241,8 +242,10 @@ class BooleanChoices:
def save(self, resp: flask.Response): def save(self, resp: flask.Response):
"""Save cookie in the HTTP reponse obect""" """Save cookie in the HTTP reponse obect"""
resp.set_cookie('disabled_{0}'.format(self.name), ','.join(self.disabled), max_age=COOKIE_MAX_AGE) disabled_changed = (k for k in self.disabled if self.default_choices[k])
resp.set_cookie('enabled_{0}'.format(self.name), ','.join(self.enabled), max_age=COOKIE_MAX_AGE) enabled_changed = (k for k in self.enabled if not self.default_choices[k])
resp.set_cookie('disabled_{0}'.format(self.name), ','.join(disabled_changed), max_age=COOKIE_MAX_AGE)
resp.set_cookie('enabled_{0}'.format(self.name), ','.join(enabled_changed), max_age=COOKIE_MAX_AGE)
def get_disabled(self): def get_disabled(self):
return self.transform_values(list(self.disabled)) return self.transform_values(list(self.disabled))