syuilo
7562d233c5
fix of 9a70ce8f5e
...
Co-Authored-By: RyotaK <49341894+Ry0taK@users.noreply.github.com>
2024-02-17 13:09:16 +00:00
tamaina
0a8ffd9cfa
Merge pull request from GHSA-qqrm-9grj-6v32
...
* maybe ok
* fix
* test wip
* ✌️
* fix
* if (res.ok)
* validateContentTypeSetAsJsonLD
* 条件を考慮し直す
* その他の+json接尾辞が付いているメディアタイプも受け容れる
* https://github.com/misskey-dev/misskey-ghsa-qqrm-9grj-6v32/pull/1#discussion_r1490999009
* add `; profile="https://www.w3.org/ns/activitystreams "`
* application/ld+json;
2024-02-17 13:09:08 +00:00
Amelia Yukii
be36a793cd
merge: Fix Note Edits being federated incorrectly ( !417 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/417
Approved-by: Amelia Yukii <amelia.yukii@shourai.de>
Approved-by: dakkar <dakkar@thenautilus.net>
2024-02-15 22:18:58 +00:00
Marie
8b90c6c045
merge: Never return broken notifications #409 ( !415 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/415
Approved-by: Marie <marie@kaifa.ch>
Approved-by: Amelia Yukii <amelia.yukii@shourai.de>
2024-02-13 18:23:37 +00:00
dakkar
1015901a9d
avoid parsing undefined
...
I don't understand why upstream wouldn't have this same problem ☹
We already have this same conditional in `ApRenderService.renderNote`
and `ApRenderService.renderUpNote`, and Misskey doesn't
2024-02-13 14:04:07 +00:00
Marie
fef5dbb6e2
fix: note edits being federated incorrectly
2024-02-13 13:08:44 +00:00
dakkar
421f8d49e5
Never return broken notifications #409
...
Since notifications are stored in Redis, we can't expect relational
integrity: deleting a user will *not* delete notifications that
mention it.
But if we return notifications with missing bits (a `follow` without a
`user`, for example), the frontend will get very confused and throw an
exception while trying to render them.
This change makes sure we never expose those broken notifications. For
uniformity, I've applied the same logic to notes and roles mentioned
in notifications, even if nobody reported breakage in those cases.
Tested by creating a few types of notifications with a `notifierId`,
then deleting their user.
2024-02-11 12:25:50 +00:00
Marie
2e7df3297c
fix: diff between NoteCreateService and NoteEditService
2024-02-09 19:51:41 +01:00
Marie
85355813ad
merge: latest changes
2024-02-09 19:22:06 +01:00
おさむのひと
614c9a0fc6
fix: 特定文字列を含むノートを投稿できないようにする管理画面用設定項目を追加 ( #13210 )
...
* fix: 特定文字列を含むノートを投稿できないようにする管理画面用設定項目を追加
* Serviceでチェックするように変更
2024-02-09 10:07:18 +09:00
かっこかり
0f7918c51b
refactor(backend): exist -> exists ( #13203 )
...
* refactor(backend): exist -> exists
* fix
2024-02-08 16:04:41 +09:00
Marie
af5ebdfced
merge: more upstream changes
2024-02-07 21:52:27 +01:00
MeiMei
e89d760240
Enhance: 連合向けのノート配信を軽量化 ( #13192 )
...
* AP HTML表現をシンプルに
* a
* CHANGELOG
* リンク
2024-02-07 19:57:59 +09:00
Marie
6a94a52131
merge: upstream
2024-02-06 21:23:37 +01:00
MeiMei
d6cb68b091
AP Key の JSON-LD 表現を修正 ( #13170 )
2024-02-06 16:51:14 +09:00
1Step621
74245df382
Enhance(frontend): フロント側でもリアクション権限のチェックをするように ( #13134 )
...
* フロント側でもリアクション権限のチェックをするように
* update CHANGELOG.md
* lint fixes
* remove unrelated diffs
* deny -> reject
denyは「(信用しないことを理由に)拒否する」という意味らしい
* allow -> accept
* EmojiSimpleにlocalOnlyを含めるように
* リアクション権限のない絵文字は打てないように(ダイアログを出すのではなく)
* regenerate type definitions
* lint fix
* remove unused locales
* remove unnecessary async
2024-02-06 16:45:21 +09:00
Gianni Ceccarelli
dabf1867fd
keep cached avatar&banner when refresh fails to get new values ( #13145 )
...
* keep cached avatar&banner when refresh fails to get new values
when the remote explicitly tells us a user image is gone, we remove
our cached value, but if we fail to get the image, we keep whatever
value we already have
this should minimise the problem of avatars randomly disappearing
* autogen bits
* pnpm run build-misskey-js-with-types
---------
Co-authored-by: tamaina <tamaina@hotmail.co.jp>
2024-02-04 21:03:49 +09:00
Gianni Ceccarelli
bafef1f8b4
ignore instance.actor
when checking if there are local users ( #13146 )
...
* ignore `instance.actor` when checking if there are local users
We've seen this happen a few times:
* there was some AP software at $some_domain
* it gets replaced by Misskey
* before the first user can be created, an AP activity comes in
* Misskey resolves the activity
* to do this, it creates the `instance.actor` to sign its request
* now there *is* a local user, so the `meta` endpoint returns
`requireSetup:false`
* the admin is very confused
This commit factors out the check, and doesn't count the
`instance.actor` as a real user.
* autogen bits
2024-02-04 20:46:28 +09:00
atsuchan
2c4ba4723f
fix(backend): メール配信機能が無効ならばメールを送ることのないように ( #13152 )
...
Do not send email if email delivery is disabled
2024-02-04 20:44:35 +09:00
Marie
11628e4b6a
merge: upstream
2024-02-03 20:19:44 +01:00
Marie
f93a8e2d38
merge: Fix sfm-js linkage ( !399 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/399
Approved-by: Amelia Yukii <amelia.yukii@shourai.de>
Approved-by: dakkar <dakkar@thenautilus.net>
2024-02-03 18:28:47 +00:00
Marie
f091b84c6e
chore: change sfm registry and name
2024-02-03 15:01:09 +01:00
tamaina
b0a38c0cae
fix: Hide reactions of all remote users / feat: moderators can see reactions of all users ( #13128 )
...
* fix: Hide reactions of all remote users
https://github.com/misskey-dev/misskey/issues/12964
* feat: Moderators can see reactions of all users
https://github.com/misskey-dev/misskey/issues/13127
* modify CHANGELOG.md
* fix iAmModerator
2024-02-01 20:05:45 +09:00
zyoshoka
2db5b61616
refactor(backend): User関連のスキーマ/型の指定を強くする ( #12808 )
...
* refactor(backend): User関連のスキーマ/型の指定を強くする
* refactor(backend): `pack()`の引数にスキーマを指定するように
* chore: fix ci
* fix: 変更漏れ
* fix ci
---------
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
2024-01-31 15:45:35 +09:00
yukineko
a6a91fec3a
refactor: frontendのcomponentsの型エラーを改善 ( #12926 )
...
* add: safeFloatParserを追加
* fix: 欠けていた型を追加
* refactor: pageBlockTypesをjson-schemaに移植
* refactor: components/global内の型エラーが出ている箇所を修正
* lint: fix null check style
* refactor: fix type error
* refactor: fix some type errors
* fix: 翻訳が抜けていた箇所を修正
* refactor: getJsonSchemaで正しいスキーマが返されるように修正
* fix: MkChartの型エラーとbytesオプションが機能していない問題を修正
* fix(misskey-js): `drive`->`folderUpdated`のpayloadの型が間違っていたのを修正
* refactor: fix some type errors
* change: Captcha読み込み中の文言をLoadingに変更
* refactor(backend/misskey-js): MainEventの型を改善
* refactor: chartjs-plugin-gradientが二重でpluginに登録されていたのを修正
* update: misskey-js.api.md
* refactor: fix some type errors
* fix: backendのtypecheckが落ちていたのを修正
* update: misskey-js.api.md
* add: json-schemaのnoteにpollの型定義を追加
* refactor: noteのjson-schemaの型を改善
* refactor: MkPoll
* refactor: fix some type errors
* change: UserLiteにisLockedを持たせるように
* fix: notificationスキーマにroleが含まれていないのを修正
* Revert "change: UserLiteにisLockedを持たせるように"
This reverts commit 1bb0c8e7a9b19a4e9f21bf7381712b98f27672a5.
* fix: フォロー通知から鍵垢へのフォローを行うと処理中のまま止まってしまう問題を修正
* refactor: noteスキーマのvisibilityにenumを追加
* change: deepCloneのCloneableTypeにundefinedを追加
* refactor: fix some type errors
* refactor: `allowEmpty: false`を使用していた箇所を`minLength: 1`に置き換え
* enhance: API 'retension' のresponseの型を追加
* fix: Chart関連のtooltipが正しい位置に表示されない問題を修正
* refactor: fix some type errors
* fix: 型情報が不足していたのを修正
* enhance: announcementスキーマにenumを追加
* enhance: ロールポリシーの型定義をRoleServiceからjson-schemaに移植
* refactor: policiesを`ref: RolePolicies`に統一
* fix: API `meta` のレスポンスの型にpoliciesが含まれていないのを修正
* refactor: fix some type errors
* fix: backendのlintが落ちているのを修正
* fix: MkFoldableSectionの開閉時のanimationが適用されていない問題を修正
* fix: backendのtypecheckが落ちているのを修正
* update: run build-misskey-js-with-types
* fix: MkDialogのmount時に文字数制限の判定が行われない問題を修正
* update: CHANGELOG.md
* refactor: MkUserSelectDialogの型を改善
* fix: deepCloneでundefinedはcloneしないように (#9207 )
* change: frontendのcloneをbackend側にも反映
* update: CHANGELOG.md
* fix: RoleServiceからPackを通して型RolePoliciesに依存させないように
* Update packages/frontend/src/scripts/get-note-summary.ts
* revert RoleService.ts changes
* change: optional chaining -> non-null assertion
* remove: unused import
* fix: propsで渡されたuserがUserLiteの場合に意図しない動作になってしまうのを修正
* change: fix null check style
* refactor: fix type error
* change: fix null check style
* Update packages/frontend/src/components/MkDrive.vue
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
* refactor: css moduleでglobalを使わないように
* refactor: roleのiconUrlは必ず存在するものとして扱うように
* enhance: MenuButtonのactiveにcomputedを受け付けられるように
* Update packages/frontend/src/components/MkNotePreview.vue
* Update MkWindow.vue
* refactor: notification.noteは必ず存在するものとして扱うように
* Update packages/frontend/src/components/MkNotification.vue
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
* fix: MkSignupDialogでdoneのemit時にresを含んでいなかったのを修正
* Update packages/frontend/src/scripts/clone.ts
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
* refactor: 不要な返り値の型を削除
* refactor: 不要なnullチェックを削除
* update: misskey-js-autogen
* update: clone.ts
* refactor
* Update MkNotification.vue
* Update MkNotification.vue
* ✌️
* Update MkNotification.vue
* Update MkNotification.vue
* Update MkNotification.vue
* Update MkNotifications.vue
* Update MkUserSetupDialog.Profile.vue
* Update MkUserCardMini.vue
* ✌️
* Update MkMenu.vue
---------
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
2024-01-30 19:53:53 +09:00
dakkar
e93e73673a
probably more correct muting logic
...
we want to notify if neither the thread nor the user are muted;
otherwise, for example, notes in a muted thread from a non-muted user
would get notified
2024-01-26 18:09:25 +00:00
dakkar
b0fcc11d9e
null-ify text after trimming
...
this comes from upstream, it's already present in the "import"
section, I think it was missed in a merge
2024-01-26 18:07:49 +00:00
dakkar
83e9057b27
apply to NoteEditService all recent changes from NoteCreateService
2024-01-26 18:07:34 +00:00
Marie
e5c060eecf
fix: don't show mentions and boosts towards muted user posts in timeline
...
Closes #336
2024-01-26 01:59:19 +01:00
Marie
47cf7f6822
fix: don't show replies to muted users in timelines
...
Closes #337
2024-01-26 01:39:01 +01:00
Marie
6c6ccdc1e0
fix: properly mute notifications when mentioned by muted users
...
Closes #339
2024-01-26 01:24:26 +01:00
Marie
e89f4ff3c8
fix: boosts not being muted when muting thread
...
Closes #347
2024-01-25 19:39:41 +01:00
Marie
913dd581ef
merge: upstream
2024-01-25 14:21:42 +01:00
syuilo
60156a40b2
fix(reversi/backend): refactor and fixes
2024-01-24 16:44:12 +09:00
syuilo
5719a929ad
enhance(reversi): 変則なしマッチングを可能に
2024-01-24 16:37:06 +09:00
syuilo
d27b3525cd
enhance(reversi): improve matching system
2024-01-24 15:18:50 +09:00
syuilo
a97d4fa4ef
fix(reversi): wait redis operation to improve stability
2024-01-24 13:53:55 +09:00
syuilo
908e0f3b8b
perf(reversi): set expire matchSpecific and matchAny
2024-01-24 13:51:16 +09:00
syuilo
b68446b289
enhance(reversi): tweak MATCHING_TIMEOUT_MS
2024-01-24 13:32:08 +09:00
syuilo
547be1973d
fix of 65557d5f27
2024-01-24 10:35:44 +09:00
syuilo
65557d5f27
enhance(reversi): more robust matching process
2024-01-24 10:16:05 +09:00
syuilo
e8ba0b3f54
enhance(reversi): improve desync handling
2024-01-23 10:51:59 +09:00
Marie
d15e4a85bb
chore: typecheck
2024-01-22 22:13:10 +01:00
Marie
fd69a2fbbd
merge: upstream
2024-01-22 19:58:43 +01:00
syuilo
d380ed36de
fix lint
2024-01-22 18:00:46 +09:00
syuilo
4af3640bd3
fix lint
2024-01-22 17:44:03 +09:00
syuilo
94e282b612
perf(reversi): improve performance of reversi backend
2024-01-22 15:41:29 +09:00
syuilo
a431dde537
refactor(reversi): refactoring of reversi backend
2024-01-22 09:29:06 +09:00
syuilo
1a01a85182
perf(reversi): improve performance of reversi backend
2024-01-22 08:39:38 +09:00
Marie
db012fc8c3
merge: upstream (1)
2024-01-21 13:11:23 +01:00