HoovesSocial/hippofish
2
0
Fork 0
Code Issues 3 Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix: pagination

Browse source
This commit is contained in:
Namekuji 2023-08-05 02:47:04 -04:00
parent baf3387be1
commit f8387be81a
No known key found for this signature in database
GPG key ID: 1D62332C07FBA532
2 changed files with 30 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/backend/src/misc/gen-id.ts
View file

@ -19,3 +19,9 @@ nativeInitIdGenerator(length, fingerprint);
export function genId(date?: Date): string {
return nativeCreateId((date ?? new Date()).getTime());
}
const TIME_2000 = 946_684_800_000;
export function getTimestamp(id: string): number {
return parseInt(id.slice(0, 8), 36) + TIME_2000;
}

32
packages/backend/src/server/api/endpoints/notes/timeline.ts
View file

@ -20,6 +20,7 @@ import {
filterReply,
} from "@/db/scylla.js";
import { LocalFollowingsCache } from "@/misc/cache.js";
import { getTimestamp } from "@/misc/gen-id.js";
export const meta = {
tags: ["notes"],
@ -79,22 +80,35 @@ export default define(meta, paramDef, async (ps, user) => {
let untilDate = new Date();
const foundNotes: ScyllaNote[] = [];
const validIds = [user.id].concat(await followingsCache.getAll());
const query = `${prepared.note.select.byDate} AND "createdAt" < ? LIMIT 50`; // LIMIT is hardcoded to prepare
while (foundNotes.length < ps.limit) {
const query = [`${prepared.note.select.byDate} AND "createdAt" < ?`];
const params: (Date | string | string[])[] = [untilDate, untilDate];
if (ps.untilId) {
query.push(`AND "id" < ?`);
params.push(ps.untilId);
untilDate = new Date(getTimestamp(ps.untilId));
}
query.push("LIMIT 50"); // Hardcoded for prepared query
const result = await scyllaClient.execute(query.join(" "), params, {
let scanned_partitions = 0;
// Try to get posts of at most 30 days in the single request
while (foundNotes.length < ps.limit && scanned_partitions < 30) {
const params: (Date | string | string[])[] = [untilDate, untilDate];
const result = await scyllaClient.execute(query, params, {
prepare: true,
});
if (result.rowLength === 0) {
break;
// Reached the end of partition. Queries posts created one day before.
scanned_partitions++;
untilDate = new Date(
untilDate.getUTCFullYear(),
untilDate.getUTCMonth(),
untilDate.getUTCDate() - 1,
23,
59,
59,
999,
);
continue;
}
const notes = result.rows.map(parseScyllaNote);
@ -108,7 +122,7 @@ export default define(meta, paramDef, async (ps, user) => {
untilDate = notes[notes.length - 1].createdAt;
}
return Notes.packMany(foundNotes, user);
return Notes.packMany(foundNotes.slice(0, ps.limit), user);
}
const hasFollowing = await followingsCache.hasFollowing();