From e3ac600e5e20c534d005b2589e66898f10865a65 Mon Sep 17 00:00:00 2001
From: naskya <m@naskya.net>
Date: Wed, 3 Jul 2024 10:46:04 +0900
Subject: [PATCH] meta: update issue/merge request templates (closes #10942)

---
 .gitlab/issue_templates/bug.md             | 61 ++++++++++++++++++----
 .gitlab/issue_templates/feature.md         | 46 +++++++++++++---
 .gitlab/issue_templates/refactor.md        | 58 ++++++++++++++++++++
 .gitlab/merge_request_templates/default.md | 17 +++---
 .gitlab/merge_request_templates/release.md |  3 +-
 5 files changed, 160 insertions(+), 25 deletions(-)
 create mode 100644 .gitlab/issue_templates/refactor.md

diff --git a/.gitlab/issue_templates/bug.md b/.gitlab/issue_templates/bug.md
index f96bdec01e..94b97b7626 100644
--- a/.gitlab/issue_templates/bug.md
+++ b/.gitlab/issue_templates/bug.md
@@ -3,24 +3,48 @@
 🔒 Found a security vulnerability? [Please disclose it responsibly.](https://firefish.dev/firefish/firefish/-/blob/develop/SECURITY.md)
 🤝 By submitting this issue, you agree to follow our [Contribution Guidelines.](https://firefish.dev/firefish/firefish/-/blob/develop/CONTRIBUTING.md) -->
 
-## What happened? <!-- Please give us a brief description of what happened. -->
+## What type of issue is this?
+<!-- If this happens on your device and has to do with the user interface, it's client-side. If this happens on either with the API or the backend, or you got a server-side error in the client, it's server-side. -->
+
+<!-- Uncomment (remove surrounding arrow signs) the following line(s) to specify the category of this issue. -->
+<!-- /label Server -->
+<!-- /label Client -->
+<!-- /label Mobile -->
+<!-- /label "Third-party client" -->
+<!-- /label Docs -->
+<!-- /label "Build from source" -->
+<!-- /label Container -->
+<!-- /label "Firefish API" -->
+<!-- /label "Mastodon API" -->
+
+## What happened?
+<!-- Please give us a brief description of what happened. -->
 
 
-## What did you expect to happen? <!-- Please give us a brief description of what you expected to happen. -->
+## What did you expect to happen?
+<!-- Please give us a brief description of what you expected to happen. -->
 
 
-## Version <!-- What version of firefish is your instance running? You can find this by clicking your instance's logo at the bottom left and then clicking instance information. -->
+## Steps to reproduce the issue
+<!-- Please describe how to reproduce this issue (preferably, in a ordered list) -->
 
 
-## What type of issue is this? <!-- If this happens on your device and has to do with the user interface, it's client-side. If this happens on either with the API or the backend, or you got a server-side error in the client, it's server-side. -->
+## Reproduces how often
+<!-- Is it always reproducible, or is it conditional/probabilistic ? -->
+
+
+## What did you try to solve the issue
+<!-- Not to repeat the same thing, let us share what you have tried so far. -->
+
+
+## Version
+<!-- What version of firefish is your instance running? You can find this by the instance information page. -->
 
-- [ ] server-side
-- [ ] client-side
-- [ ] not sure
 
 <details>
 
-### Instance <!-- What instance of firefish are you using? -->
+### Instance
+<!-- What instance of firefish are you using? -->
 
 
 ### What browser are you using? (client-side issues only)
@@ -35,7 +59,8 @@
 ### What operating system are you using? (Server-side issues only)
 
 
-### Relevant log output <!-- Please copy and paste any relevant log output. You can find your log by inspecting the page, and going to the "console" tab. -->
+### Relevant log output
+<!-- Please copy and paste any relevant log output. -->
 
 
 </details>
@@ -46,4 +71,20 @@ By submitting this issue, you agree to follow our [Contribution Guidelines](http
 - [ ] I have searched the issue tracker for similar issues, and this is not a duplicate.
 
 ## Are you willing to fix this bug? (optional)
-- [ ] Yes. I will fix this bug and open a merge request if the change is agreed upon.
+<!-- Please uncomment the following line if you want to fix this bug -->
+<!-- /assign me -->
+
+<!--
+	Please tell us how to fix this bug.
+	As noted in the contribution guidelines, there is a good chance that your
+	merge request will not be merged if there is no agreement with the project maintainers.
+	However, we are currently so understaffed that it is virtually impossible to
+	respond to every single proposal. So, feel free to implement it if there is no response
+	for more than a week or there is a thumbs-up emoji reaction from the project maintainer(s).
+-->
+
+
+
+
+<!-- Do not edit the following line -->
+/label Bug?
diff --git a/.gitlab/issue_templates/feature.md b/.gitlab/issue_templates/feature.md
index 4c9ee56226..280cc59003 100644
--- a/.gitlab/issue_templates/feature.md
+++ b/.gitlab/issue_templates/feature.md
@@ -1,18 +1,36 @@
 <!-- 💖 Thanks for taking the time to fill out this bug report!
 💁 Having trouble with deployment? [Ask the support chat.](https://matrix.to/#/#firefish-community:nitro.chat)
 🔒 Found a security vulnerability? [Please disclose it responsibly.](https://firefish.dev/firefish/firefish/-/blob/develop/SECURITY.md)
-🤝 By submitting this feature request, you agree to follow our [Contribution Guidelines.](https://firefish.dev/firefish/firefish/-/blob/develop/CONTRIBUTING.md) -->
+🤝 By submitting this refactor proposal, you agree to follow our [Contribution Guidelines.](https://firefish.dev/firefish/firefish/-/blob/develop/CONTRIBUTING.md) -->
 
-## What feature would you like implemented? <!-- Please give us a brief description of what you'd like. -->
+## What type of refactoring is this?
+<!-- If this happens on your device and has to do with the user interface, it's client-side. If this happens on either with the API or the backend, or you got a server-side error in the client, it's server-side. -->
+
+<!-- Uncomment (remove surrounding arrow signs) the following line(s) to specify the category of this issue. -->
+<!-- /label Server -->
+<!-- /label Client -->
+<!-- /label Mobile -->
+<!-- /label "Third-party client" -->
+<!-- /label Docs -->
+<!-- /label "Build from source" -->
+<!-- /label Container -->
+<!-- /label "Firefish API" -->
+<!-- /label "Mastodon API" -->
+
+## What feature would you like implemented?
+<!-- Please give us a brief description of what you'd like to be refactored. -->
 
 
-## Why should we add this feature? <!-- Please give us a brief description of why your feature is important. -->
+## Why should we add this feature?
+<!-- Please give us a brief description of why your feature is important. -->
 
 
-## Version <!-- What version of firefish is your instance running? You can find this by clicking your instance's logo at the bottom left and then clicking instance information. -->
+## Version
+<!-- What version of firefish is your instance running? You can find this by clicking your instance's logo at the bottom left and then clicking instance information. -->
 
 
-## Instance <!-- What instance of firefish are you using? -->
+## Instance
+<!-- What instance of Firefish are you using? -->
 
 
 ## Contribution Guidelines
@@ -21,4 +39,20 @@ By submitting this issue, you agree to follow our [Contribution Guidelines](http
 - [ ] I have searched the issue tracker for similar requests, and this is not a duplicate.
 
 ## Are you willing to implement this feature? (optional)
-- [ ] Yes. I will implement this feature and open a merge request if the change is agreed upon.
+<!-- Please uncomment the following line if you want to implement this feature -->
+<!-- /assign me -->
+
+<!--
+	Please tell us how to implement this feature.
+	As noted in the contribution guidelines, there is a good chance that your
+	merge request will not be merged if there is no agreement with the project maintainers.
+	However, we are currently so understaffed that it is virtually impossible to
+	respond to every single proposal. So, feel free to implement it if there is no response
+	for more than a week or there is a thumbs-up emoji reaction from the project maintainer(s).
+-->
+
+
+
+
+<!-- Do not edit the following line -->
+/label Feature
diff --git a/.gitlab/issue_templates/refactor.md b/.gitlab/issue_templates/refactor.md
new file mode 100644
index 0000000000..3cb03a3775
--- /dev/null
+++ b/.gitlab/issue_templates/refactor.md
@@ -0,0 +1,58 @@
+<!-- 💖 Thanks for taking the time to fill out this report!
+💁 Having trouble with deployment? [Ask the support chat.](https://matrix.to/#/#firefish-community:nitro.chat)
+🔒 Found a security vulnerability? [Please disclose it responsibly.](https://firefish.dev/firefish/firefish/-/blob/develop/SECURITY.md)
+🤝 By submitting this feature request, you agree to follow our [Contribution Guidelines.](https://firefish.dev/firefish/firefish/-/blob/develop/CONTRIBUTING.md) -->
+
+## What type of feature is this?
+<!-- If this happens on your device and has to do with the user interface, it's client-side. If this happens on either with the API or the backend, or you got a server-side error in the client, it's server-side. -->
+
+<!-- Uncomment (remove surrounding arrow signs) the following line(s) to specify the category of this issue. -->
+<!-- /label Server -->
+<!-- /label Client -->
+<!-- /label Mobile -->
+<!-- /label "Third-party client" -->
+<!-- /label Docs -->
+<!-- /label "Build from source" -->
+<!-- /label Container -->
+<!-- /label "Firefish API" -->
+<!-- /label "Mastodon API" -->
+
+## What parts of the code do you think should be refactored?
+<!-- Please give us a brief description of what you'd like. -->
+
+
+## Why should the code be refactored that way?
+<!-- Please give us a brief description of the reason of your proposal. -->
+
+
+## Version
+<!-- What version of firefish is your instance running? You can find this by clicking your instance's logo at the bottom left and then clicking instance information. -->
+
+
+## Instance
+<!-- What instance of Firefish are you using? -->
+
+
+## Contribution Guidelines
+By submitting this issue, you agree to follow our [Contribution Guidelines](https://firefish.dev/firefish/firefish/-/blob/develop/CONTRIBUTING.md)
+- [ ] I agree to follow this project's Contribution Guidelines
+- [ ] I have searched the issue tracker for similar requests, and this is not a duplicate.
+
+## Are you willing to refactor the code? (optional)
+<!-- Please uncomment the following line if you want to implement it -->
+<!-- /assign me -->
+
+<!--
+	Please tell us how to refactor the code.
+	As noted in the contribution guidelines, there is a good chance that your
+	merge request will not be merged if there is no agreement with the project maintainers.
+	However, we are currently so understaffed that it is virtually impossible to
+	respond to every single proposal. So, feel free to implement it if there is no response
+	for more than a week or there is a thumbs-up emoji reaction from the project maintainer(s).
+-->
+
+
+
+
+<!-- Do not edit the following line -->
+/label Refactor
diff --git a/.gitlab/merge_request_templates/default.md b/.gitlab/merge_request_templates/default.md
index d13a146da0..6d09072a87 100644
--- a/.gitlab/merge_request_templates/default.md
+++ b/.gitlab/merge_request_templates/default.md
@@ -1,16 +1,19 @@
-<!-- Thanks for taking the time to make Firefish better! It's not required, but please consider using [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) when making your commits. If you use VSCode, please use the [Conventional Commits extension](https://marketplace.visualstudio.com/items?itemName=vivaxy.vscode-conventional-commits). -->
+<!-- Thanks for taking the time to make Firefish better! -->
 
-## What does this PR do? <!-- Please give us a brief description of what this PR does. -->
+## What does this merge request do?
+<!-- Please give us a brief description of what this merge request does. -->
 
 
 ## Contribution Guidelines
 By submitting this merge request, you agree to follow our [Contribution Guidelines](https://firefish.dev/firefish/firefish/-/blob/develop/CONTRIBUTING.md)
-- [ ] This change is reviewed in an issue / This is a minor bug fix
-- [ ] I agree to follow this project's Contribution Guidelines
-- [ ] I have made sure to test this pull request
-- [ ] I have made sure to run `pnpm run format` before submitting this pull request
+- [ ] This closes issue #0000 (please substitute the number)
+- [ ] This is a minor bug fix or refactoring
 
-If this merge request makes changes to the Firefish API, please update `docs/api-change.md`
+- [ ] I agree to follow this project's Contribution Guidelines
+- [ ] I have made sure to test this merge request
+- [ ] I have made sure to run `pnpm run format` before submitting this merge request
+
+If this merge request makes changes to API, please update `docs/api-change.md`
 - [ ] I updated the document / This merge request doesn't include API changes
 
 <!-- Uncomment if your merge request has multiple authors -->
diff --git a/.gitlab/merge_request_templates/release.md b/.gitlab/merge_request_templates/release.md
index ea40f38813..6b83d5fdc4 100644
--- a/.gitlab/merge_request_templates/release.md
+++ b/.gitlab/merge_request_templates/release.md
@@ -1,4 +1,5 @@
 <!-- This template is used only when merging the develop branch into the main branch. Please don't use this for other merge requests. -->
+/label Release
 
 ## Checklist
 
@@ -13,7 +14,5 @@ I have updated...
 - [ ] `packages/backend-rs/index.js`
 - [ ] OCI container image
 
-<!-- TODO: Add automated tests (task runners are currently down) -->
-
 ## Remarks