HoovesSocial/hippofish
2
0
Fork 0
Code Issues 3 Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix (dev): FIREFISH_URL is a redundant variable

Browse source
This commit is contained in:
naskya 2024-03-04 01:45:25 +09:00
parent 05fa00b586
commit 95baffff63
No known key found for this signature in database
GPG key ID: 712D413B3A9FED5C
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
dev/docker-entrypoint.sh
View file

@ -3,8 +3,6 @@
set -xeu
node --version
FIREFISH_URL='http://localhost:3030'
# Check Environment Initialized Flag
if [ ! -f '/.firefish_env_initialized' ]; then
@ -26,7 +24,7 @@ if [ ! -f '/.firefish_env_initialized' ]; then
cd /firefish
cp .config/devenv.yml .config/default.yml
URL="$(echo "${FIREFISH_URL}" | sed 's#/#\\/#g')"
URL="$(echo "${URL}" | sed 's#/#\\/#g')"
sed -i'.bak' "s/http:\/\/localhost:3030/${URL}/g" .config/default.yml
rm .config/defaut.yml.bak

2
docs/development.md
View file

@ -17,7 +17,7 @@ The Firefish repo comes with a new containerized environment to help make develo
1. Run `git clone https://firefish.dev/firefish/firefish.git && cd firefish` to fetch needed files.
- If you don't want to clone the entire repository, you can just download the [`dev` directory](https://firefish.dev/firefish/firefish/-/tree/develop/dev) and execute `chmod +x dev/docker-entrypoint.sh`.
1. Open `dev/docker-compose.yml` and set `FIREFISH_URL` to the URL you want to use (or leave it to `http://localhost:3030`).
1. Open `dev/docker-compose.yml` and set `URL` to the URL you want to use (or leave it to `http://localhost:3030`).
1. Run `docker compose --file dev/docker-compose.yml up`. This will build the environment, dependencies and prepare the needed config files.
- If you use Podman, you should run `podman-compose --file dev/docker-compose.yml up` instead.
1. Wait until the following message shows up.