HoovesSocial/hippofish
2
0
Fork 0
Code Issues 3 Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix: pagination limit

Browse source
This commit is contained in:
Namekuji 2023-08-10 03:06:05 -04:00
parent e74b7bab49
commit 7dd5372337
No known key found for this signature in database
GPG key ID: 1D62332C07FBA532
1 changed files with 13 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
packages/backend/src/db/scylla.ts
View file

@ -238,6 +238,8 @@ export interface ScyllaNoteReaction extends NoteReaction {
emoji: PopulatedEmoji; emoji: PopulatedEmoji;
} }
const QUERY_LIMIT = 1000;
export function parseScyllaReaction(row: types.Row): ScyllaNoteReaction { export function parseScyllaReaction(row: types.Row): ScyllaNoteReaction {
return { return {
id: row.get("id"), id: row.get("id"),
@ -280,7 +282,7 @@ export function prepareNoteQuery(ps: {
queryParts.push(`AND "createdAt" > ?`); queryParts.push(`AND "createdAt" > ?`);
} }
queryParts.push("LIMIT 100"); queryParts.push(`LIMIT ${QUERY_LIMIT}`);
const query = queryParts.join(" "); const query = queryParts.join(" ");
@ -307,11 +309,11 @@ export async function execNotePaginationQuery(
let { query, untilDate, sinceDate } = prepareNoteQuery(ps); let { query, untilDate, sinceDate } = prepareNoteQuery(ps);
let scannedEmptyPartitions = 0; let scannedPartitions = 0;
const foundNotes: ScyllaNote[] = []; const foundNotes: ScyllaNote[] = [];
// Try to get posts of at most <maxDays> in the single request // Try to get posts of at most <maxDays> in the single request
while (foundNotes.length < ps.limit && scannedEmptyPartitions < maxDays) { while (foundNotes.length < ps.limit && scannedPartitions < maxDays) {
const params: (Date | string | string[] | number)[] = []; const params: (Date | string | string[] | number)[] = [];
if (ps.noteId) { if (ps.noteId) {
params.push(ps.noteId, untilDate); params.push(ps.noteId, untilDate);
@ -326,22 +328,20 @@ export async function execNotePaginationQuery(
prepare: true, prepare: true,
}); });
if (result.rowLength === 0) { if (result.rowLength > 0) {
const notes = result.rows.map(parseScyllaNote);
foundNotes.push(...(filter ? await filter(notes) : notes));
untilDate = notes[notes.length - 1].createdAt;
}
if (result.rowLength < QUERY_LIMIT) {
// Reached the end of partition. Queries posts created one day before. // Reached the end of partition. Queries posts created one day before.
scannedEmptyPartitions++; scannedPartitions++;
const yesterday = new Date(untilDate.getTime() - 86400000); const yesterday = new Date(untilDate.getTime() - 86400000);
yesterday.setUTCHours(23, 59, 59, 999); yesterday.setUTCHours(23, 59, 59, 999);
untilDate = yesterday; untilDate = yesterday;
if (sinceDate && untilDate < sinceDate) break; if (sinceDate && untilDate < sinceDate) break;
continue;
} }
scannedEmptyPartitions = 0;
const notes = result.rows.map(parseScyllaNote);
foundNotes.push(...(filter ? await filter(notes) : notes));
untilDate = notes[notes.length - 1].createdAt;
} }
return foundNotes; return foundNotes;