HoovesSocial/hippofish
2
0
Fork 0
Code Issues 3 Pull requests 1 Projects Releases Packages Wiki Activity Actions

refactor (backend): use Promise.all to await multiple async processes

Browse source
This commit is contained in:
naskya 2024-03-23 00:54:54 +09:00
parent 26e35d1d82
commit 6e9d3387e0
No known key found for this signature in database
GPG key ID: 712D413B3A9FED5C
1 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
packages/backend/src/services/note/delete.ts
View file

@ -22,8 +22,8 @@ async function recalculateNotesCountOfLocalUser(user: {
id: User["id"];
host: User["host"];
}) {
if (user.host == null) {
await Notes.countBy({ userId: user.id }).then((newCount) =>
if (Users.isLocalUser(user)) {
await Notes.countBy({ userId: user.id }).then((newCount: number) =>
Users.update(user.id, { updatedAt: new Date(), notesCount: newCount }),
);
}
@ -168,7 +168,7 @@ export default async function (
async function findCascadingNotes(note: Note) {
const cascadingNotes: Note[] = [];
const recursive = async (noteId: string) => {
const findRepliesAndQuotes = async (noteId: string) => {
const query = Notes.createQueryBuilder("note")
.where("note.replyId = :noteId", { noteId })
.orWhere(
@ -179,13 +179,16 @@ async function findCascadingNotes(note: Note) {
}),
)
.leftJoinAndSelect("note.user", "user");
const replies = await query.getMany();
for (const reply of replies) {
cascadingNotes.push(reply);
await recursive(reply.id);
}
const repliesAndQuotes = await query.getMany();
await Promise.all(
repliesAndQuotes.map((n: Note) => {
cascadingNotes.push(n);
return findRepliesAndQuotes(n.id);
}),
);
};
await recursive(note.id);
await findRepliesAndQuotes(note.id);
return cascadingNotes;
}