HoovesSocial/hippofish
2
0
Fork 0
Code Issues 3 Pull requests 1 Projects Releases Packages Wiki Activity Actions

ignore stale users/show responses - fixes #741

Browse source 
* person starts typing "abcd"
* request for user "abcd" is sent to server
* person continues typing "ef"
* request for user "abcdef" is sent to server
* response for user "abcdef" arrives, icon for user "abcdef" is shown
* response for user "abcd" arrives, icon for user "abcd" was shown –
  with this commit, this response is ignored instead

This is not just "showing the wrong avatar", btw: `MkSignin` uses the
`user` variable to decide whether to use 2FA, so having the wrong data
in user can make a login attempt fail.
This commit is contained in:
dakkar 2024-10-12 18:16:06 +01:00
parent f3e6b43ea4
commit 5af38db74b
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/frontend/src/components/MkSignin.vue
View file

@ -110,7 +110,9 @@ function onUsernameChange(): void {
misskeyApi('users/show', { misskeyApi('users/show', {
username: username.value, username: username.value,
}).then(userResponse => { }).then(userResponse => {
user.value = userResponse; if (userResponse.username === username.value) {
user.value = userResponse;
}
}, () => { }, () => {
user.value = null; user.value = null;
}); });