From 506420130e2d5f38e7fef5b4a20baba549f6f6ee Mon Sep 17 00:00:00 2001 From: Freeplay Date: Sat, 20 May 2023 16:42:06 -0400 Subject: [PATCH 1/8] 'Jump to Reply' to 'Jump to previous' --- locales/en-US.yml | 2 +- packages/client/src/components/MkSubNoteContent.vue | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/locales/en-US.yml b/locales/en-US.yml index b3944b1e57..9b2a9c0108 100644 --- a/locales/en-US.yml +++ b/locales/en-US.yml @@ -57,7 +57,7 @@ sendMessage: "Send a message" copyUsername: "Copy username" searchUser: "Search for a user" reply: "Reply" -jumpToReply: "Jump to Reply" +jumpToPrevious: "Jump to previous" loadMore: "Load more" showMore: "Show more" newer: "newer" diff --git a/packages/client/src/components/MkSubNoteContent.vue b/packages/client/src/components/MkSubNoteContent.vue index e2672298c4..5415ae984f 100644 --- a/packages/client/src/components/MkSubNoteContent.vue +++ b/packages/client/src/components/MkSubNoteContent.vue @@ -17,7 +17,7 @@ !note.replyId " :to="`/notes/${note.renoteId}`" - v-tooltip="i18n.ts.jumpToReply" + v-tooltip="i18n.ts.jumpToPrevious" class="reply-icon" @click.stop > @@ -70,7 +70,7 @@ v-if="!detailed && note.replyId" :to="`#${note.replyId}`" behavior="browser" - v-tooltip="i18n.ts.jumpToReply" + v-tooltip="i18n.ts.jumpToPrevious" class="reply-icon" @click.stop > From b871746b93d61acc97408a944ae0a9b5e5353cdd Mon Sep 17 00:00:00 2001 From: Freeplay Date: Sat, 20 May 2023 21:20:17 -0400 Subject: [PATCH 2/8] hide empty tabs --- .../client/src/components/MkNoteDetailed.vue | 40 ++++++++----------- packages/client/src/components/MkTab.vue | 4 ++ 2 files changed, 21 insertions(+), 23 deletions(-) diff --git a/packages/client/src/components/MkNoteDetailed.vue b/packages/client/src/components/MkNoteDetailed.vue index cf072d4ac9..a7d657e3fe 100644 --- a/packages/client/src/components/MkNoteDetailed.vue +++ b/packages/client/src/components/MkNoteDetailed.vue @@ -34,39 +34,29 @@ > - - - - - + @@ -518,6 +508,10 @@ onUnmounted(() => { overflow: clip; outline: none; scroll-margin-top: calc(var(--stickyTop) + 20vh); + &:not(:last-child) { + border-bottom: 1px solid var(--divider); + margin-bottom: 4px; + } .article { cursor: unset; padding-bottom: 0; diff --git a/packages/client/src/components/MkTab.vue b/packages/client/src/components/MkTab.vue index 29c9435476..76887a2479 100644 --- a/packages/client/src/components/MkTab.vue +++ b/packages/client/src/components/MkTab.vue @@ -86,6 +86,10 @@ export default defineComponent({ > .icon { margin-right: 6px; } + + &:empty { + display: none !important; + } } &.chips, &.underline { From da0a0503baee8d8b1afa6b040a370f56b0978069 Mon Sep 17 00:00:00 2001 From: Freeplay Date: Sat, 20 May 2023 21:46:33 -0400 Subject: [PATCH 3/8] tab fix --- packages/client/src/components/MkNoteDetailed.vue | 2 +- packages/client/src/components/MkTab.vue | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/client/src/components/MkNoteDetailed.vue b/packages/client/src/components/MkNoteDetailed.vue index a7d657e3fe..80202f2798 100644 --- a/packages/client/src/components/MkNoteDetailed.vue +++ b/packages/client/src/components/MkNoteDetailed.vue @@ -636,7 +636,7 @@ onUnmounted(() => { > :deep(.reacted-users > *) { padding-inline: 16px !important; } - > .chips { + > :deep(.underline) { padding-left: 16px !important; } } diff --git a/packages/client/src/components/MkTab.vue b/packages/client/src/components/MkTab.vue index 76887a2479..5f7cd084fe 100644 --- a/packages/client/src/components/MkTab.vue +++ b/packages/client/src/components/MkTab.vue @@ -128,6 +128,7 @@ export default defineComponent({ &.underline { padding-block: 0 !important; margin-bottom: -1px; + border-radius: 0; button { background: none !important; border-radius: 0 !important; From 55b6b6075dd8c7b6bd63cac9d60c6b9ef397637e Mon Sep 17 00:00:00 2001 From: Freeplay Date: Sun, 21 May 2023 13:10:27 -0400 Subject: [PATCH 4/8] Accessible follow button --- .../client/src/components/MkFollowButton.vue | 33 +++++++++++-------- packages/client/src/pages/user/home.vue | 1 - 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/packages/client/src/components/MkFollowButton.vue b/packages/client/src/components/MkFollowButton.vue index 12491f6ad6..0ef5868bd9 100644 --- a/packages/client/src/components/MkFollowButton.vue +++ b/packages/client/src/components/MkFollowButton.vue @@ -1,6 +1,7 @@