merge: try to avoid insert
races in FederatedInstanceService
(!683)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/683 Approved-by: Hazelnoot <acomputerdog@gmail.com> Approved-by: Marie <github@yuugi.dev>
This commit is contained in:
commit
45974a53f8
1 changed files with 20 additions and 5 deletions
|
@ -12,6 +12,8 @@ import { IdService } from '@/core/IdService.js';
|
||||||
import { DI } from '@/di-symbols.js';
|
import { DI } from '@/di-symbols.js';
|
||||||
import { UtilityService } from '@/core/UtilityService.js';
|
import { UtilityService } from '@/core/UtilityService.js';
|
||||||
import { bindThis } from '@/decorators.js';
|
import { bindThis } from '@/decorators.js';
|
||||||
|
import { QueryFailedError } from 'typeorm';
|
||||||
|
import { isDuplicateKeyValueError } from '@/misc/is-duplicate-key-value-error.js';
|
||||||
|
|
||||||
@Injectable()
|
@Injectable()
|
||||||
export class FederatedInstanceService implements OnApplicationShutdown {
|
export class FederatedInstanceService implements OnApplicationShutdown {
|
||||||
|
@ -56,11 +58,24 @@ export class FederatedInstanceService implements OnApplicationShutdown {
|
||||||
const index = await this.instancesRepository.findOneBy({ host });
|
const index = await this.instancesRepository.findOneBy({ host });
|
||||||
|
|
||||||
if (index == null) {
|
if (index == null) {
|
||||||
const i = await this.instancesRepository.insertOne({
|
let i;
|
||||||
id: this.idService.gen(),
|
try {
|
||||||
host,
|
i = await this.instancesRepository.insertOne({
|
||||||
firstRetrievedAt: new Date(),
|
id: this.idService.gen(),
|
||||||
});
|
host,
|
||||||
|
firstRetrievedAt: new Date(),
|
||||||
|
});
|
||||||
|
} catch (e: unknown) {
|
||||||
|
if (e instanceof QueryFailedError) {
|
||||||
|
if (isDuplicateKeyValueError(e)) {
|
||||||
|
i = await this.instancesRepository.findOneBy({ host });
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if (i == null) {
|
||||||
|
throw e;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
this.federatedInstanceCache.set(host, i);
|
this.federatedInstanceCache.set(host, i);
|
||||||
return i;
|
return i;
|
||||||
|
|
Loading…
Reference in a new issue